Report failed secret ranked submissions#508
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Background submissions treated successful runner completion as job success. Ranked submissions can complete runner execution while failing secret validation, leaving the leaderboard correctly unscored but the job status misleadingly marked
succeeded.Impact
Users polling submission status now see a failed job with an actionable secret-validation message instead of
succeededwith no leaderboard score.Validation
uv run --extra dev ruff check src/libkernelbot/background_submission_manager.py tests/test_background_submission_manager.pyuv run --extra dev pytest tests/test_background_submission_manager.pyDB-backed backend/leaderboard tests were attempted locally but Docker was unavailable (
/Users/mark/.docker/run/docker.sockmissing), so those should run in CI.